Revert "feat(datastore): scoped sync and capability-gated concurrency (swamp-club#350)"#1390
Merged
Conversation
… (swamp-…" This reverts commit 3c012ba.
There was a problem hiding this comment.
Adversarial Review
This is a clean revert of PR #1386 (scoped sync and capability-gated concurrency). I verified:
- No dangling references:
scopedSync,DatastoreCapabilities,capabilities(), andscopeare fully removed from all source files, test files, and the testing package.grep -rnacrosssrc/andpackages/returns zero hits for any of these symbols. - Type surfaces are consistent:
DatastoreProviderinsrc/domain/datastore/datastore_provider.ts,packages/testing/datastore_types.ts, andsrc/domain/datastore/mod.tsall agree — nocapabilities()method, noDatastoreCapabilitiesexport. DatastoreSyncOptionsin bothsrc/domain/datastore/datastore_sync_service.tsandpackages/testing/datastore_types.tsboth lack thescopefield.repo_context.tsflush logic correctly reverts to the global-lock pattern: acquirespushLockviacustomProvider.createLock(config.datastorePath), callspushChanged()without arguments, and releases the lock infinally.- Conformance tests no longer probe for
capabilities(). - All 268 lines of scoped-sync tests removed — no partial deletions or orphaned imports.
Critical / High
None.
Medium
None.
Low
None.
Verdict
PASS — Straightforward, complete revert with no residual references to the removed feature. No logic, security, or contract issues.
There was a problem hiding this comment.
Code Review
This is a clean GitHub-generated revert of PR #1386 (scoped sync and capability-gated concurrency). The revert is mechanically correct:
DatastoreCapabilitiesinterface andcapabilities()method fully removed fromDatastoreProvider— no dangling references remain anywhere in the codebase.scopefield removed fromDatastoreSyncOptionsin bothsrc/domain/datastore/datastore_sync_service.tsandpackages/testing/datastore_types.ts.acquireModelLocksinrepo_context.tscorrectly reverts to global-lock-based push.mod.tsexports are consistent with the remaining types.- Conformance tests and scoped-sync unit tests properly removed.
- CI passes on both Linux and Windows.
Blocking Issues
None.
Suggestions
None — this is a clean revert with no residual artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1386