Skip to content

Revert "feat(datastore): scoped sync and capability-gated concurrency (swamp-club#350)"#1390

Merged
stack72 merged 1 commit into
mainfrom
revert-1386-worktree-350
May 15, 2026
Merged

Revert "feat(datastore): scoped sync and capability-gated concurrency (swamp-club#350)"#1390
stack72 merged 1 commit into
mainfrom
revert-1386-worktree-350

Conversation

@stack72
Copy link
Copy Markdown
Contributor

@stack72 stack72 commented May 15, 2026

Reverts #1386

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adversarial Review

This is a clean revert of PR #1386 (scoped sync and capability-gated concurrency). I verified:

  • No dangling references: scopedSync, DatastoreCapabilities, capabilities(), and scope are fully removed from all source files, test files, and the testing package. grep -rn across src/ and packages/ returns zero hits for any of these symbols.
  • Type surfaces are consistent: DatastoreProvider in src/domain/datastore/datastore_provider.ts, packages/testing/datastore_types.ts, and src/domain/datastore/mod.ts all agree — no capabilities() method, no DatastoreCapabilities export.
  • DatastoreSyncOptions in both src/domain/datastore/datastore_sync_service.ts and packages/testing/datastore_types.ts both lack the scope field.
  • repo_context.ts flush logic correctly reverts to the global-lock pattern: acquires pushLock via customProvider.createLock(config.datastorePath), calls pushChanged() without arguments, and releases the lock in finally.
  • Conformance tests no longer probe for capabilities().
  • All 268 lines of scoped-sync tests removed — no partial deletions or orphaned imports.

Critical / High

None.

Medium

None.

Low

None.

Verdict

PASS — Straightforward, complete revert with no residual references to the removed feature. No logic, security, or contract issues.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This is a clean GitHub-generated revert of PR #1386 (scoped sync and capability-gated concurrency). The revert is mechanically correct:

  • DatastoreCapabilities interface and capabilities() method fully removed from DatastoreProvider — no dangling references remain anywhere in the codebase.
  • scope field removed from DatastoreSyncOptions in both src/domain/datastore/datastore_sync_service.ts and packages/testing/datastore_types.ts.
  • acquireModelLocks in repo_context.ts correctly reverts to global-lock-based push.
  • mod.ts exports are consistent with the remaining types.
  • Conformance tests and scoped-sync unit tests properly removed.
  • CI passes on both Linux and Windows.

Blocking Issues

None.

Suggestions

None — this is a clean revert with no residual artifacts.

@stack72 stack72 merged commit c8ad303 into main May 15, 2026
11 checks passed
@stack72 stack72 deleted the revert-1386-worktree-350 branch May 15, 2026 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant