Share one path component iterator across syscall/#210
Merged
Conversation
path.c and sidecar.c each carry a private copy of the same '/'-separated component walk, differing only in name and return type. Promote path.c's path_next_component to external linkage and switch sidecar.c to it so the syscall layer keeps a single walker and future path predicates do not grow another copy.
Contributor
|
Thank @henrybear327 for contributing! |
henrybear327
pushed a commit
to henrybear327/elfuse
that referenced
this pull request
Jul 17, 2026
Share one path component iterator across syscall/
henrybear327
pushed a commit
to henrybear327/elfuse
that referenced
this pull request
Jul 17, 2026
Share one path component iterator across syscall/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
path.c and sidecar.c each carry a private copy of the same '/'-separated component walk, differing only in name and return type.
Promote path.c's path_next_component to external linkage and switch sidecar.c to it so the syscall layer keeps a single walker and future path predicates do not grow another copy.
Summary by cubic
Deduplicated path component iteration in the syscall layer by exporting
path_next_componentand switchingsidecar.cto use it. This keeps one '/'-component walker and aligns behavior across callers with no functional changes.path_next_component(const char **pathp, const char **comp, size_t *len)inpath.cand declared it inpath.hwith docs.sidecar_next_componentand updated call sites insidecar_translate_lookup_atto use the shared helper.Written for commit 3451457. Summary will update on new commits.