fix(ci): hydrate LFS in maketest and CodeQL - #6124
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📜 Recent review details🔇 Additional comments (2)
📝 WalkthroughWalkthroughThe CodeQL and maketest GitHub Actions workflows now enable Git LFS during repository checkout. ChangesCI Git LFS checkout
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The change enables Git LFS hydration in the two affected CI checkouts so required dependency archives are materialized; the localized workflow update is merge-ready after normal checks, with no actionable merge-blocking risk remaining. Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Code Review ✅ ApprovedEnables Git LFS hydration in the CI-maketest and C++ CodeQL workflows by setting the checkout action's lfs input to true, resolving the missing OpenSSL source archive pointer issue. No issues found. OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Important Your trial ends in 3 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more. Was this helpful? React with 👍 / 👎 | Gitar |
|



Summary
Root cause
PR #6122 vendors the OpenSSL source archive through Git LFS. These two GH-Actions workflows checked out the requested source SHA without LFS hydration, leaving
deps/libssl/openssl-3.5.7.tar.gzas a pointer file. The dependency preflight then correctly stopped the build.Setting the checkout action's
lfs: trueinput is safe for refs that do not contain LFS-tracked files; those checkouts simply have no LFS objects to materialize.Validation
git diff --checkpassesSummary by cubic
Hydrates Git LFS objects in the
ci-maketestandci-codeqlGitHub Actions checkouts. Previously these jobs skipped LFS, leavingdeps/libssl/openssl-3.5.7.tar.gzas a pointer and stopping the build; nowlfs: trueensures the archive is materialized.lfs: truetoactions/checkoutin two workflow files.Written for commit d956f45. Summary will update on new commits.
Summary by CodeRabbit