Skip to content

fix(ci): hydrate LFS in maketest and CodeQL - #6124

Merged
renecannao merged 1 commit into
GH-Actionsfrom
fix/ci-lfs-post-checkout-hydration
Aug 19, 2026
Merged

fix(ci): hydrate LFS in maketest and CodeQL#6124
renecannao merged 1 commit into
GH-Actionsfrom
fix/ci-lfs-post-checkout-hydration

Conversation

@renecannao

@renecannao renecannao commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Summary

  • enable Git LFS hydration in the CI-maketest checkout
  • enable Git LFS hydration in the C++ CodeQL checkout

Root cause

PR #6122 vendors the OpenSSL source archive through Git LFS. These two GH-Actions workflows checked out the requested source SHA without LFS hydration, leaving deps/libssl/openssl-3.5.7.tar.gz as a pointer file. The dependency preflight then correctly stopped the build.

Setting the checkout action's lfs: true input is safe for refs that do not contain LFS-tracked files; those checkouts simply have no LFS objects to materialize.

Validation

  • static checkout-block assertion failed before the change and passed afterward
  • both workflow YAML files parse successfully with PyYAML
  • git diff --check passes
  • verified the commit changes only the two affected workflow files, with one added line in each

Summary by cubic

Hydrates Git LFS objects in the ci-maketest and ci-codeql GitHub Actions checkouts. Previously these jobs skipped LFS, leaving deps/libssl/openssl-3.5.7.tar.gz as a pointer and stopping the build; now lfs: true ensures the archive is materialized.

  • Only change: add lfs: true to actions/checkout in two workflow files.
  • Safe for refs without LFS (no-op except potential minor checkout-time increase).
  • Validated: YAML parses, static checkout assertion passes, and build preflight proceeds.

Written for commit d956f45. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Chores
    • Updated automated workflows to retrieve Git LFS-managed files during repository checkout.
    • Improved consistency across code analysis and testing workflows.

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d941a48f-aea4-4d8e-afa6-036b948b662d

📥 Commits

Reviewing files that changed from the base of the PR and between 3536692 and d956f45.

📒 Files selected for processing (2)
  • .github/workflows/ci-codeql.yml
  • .github/workflows/ci-maketest.yml

Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.

📜 Recent review details
🔇 Additional comments (2)
.github/workflows/ci-codeql.yml (1)

64-64: LGTM!

.github/workflows/ci-maketest.yml (1)

49-49: LGTM!


📝 Walkthrough

Walkthrough

The CodeQL and maketest GitHub Actions workflows now enable Git LFS during repository checkout.

Changes

CI Git LFS checkout

Layer / File(s) Summary
Enable Git LFS checkout
.github/workflows/ci-codeql.yml, .github/workflows/ci-maketest.yml
Both checkout steps set lfs: true to retrieve Git LFS-managed files.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to d956f

The change enables Git LFS hydration in the two affected CI checkouts so required dependency archives are materialized; the localized workflow update is merge-ready after normal checks, with no actionable merge-blocking risk remaining.

Possibly related PRs

Poem

A rabbit checks out files with care,
LFS now fetches what was there.
CodeQL hops, maketest too,
Their workflows pull the assets through.
“No pointer left behind!” I cheer.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the CI workflows and the Git LFS hydration fix.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ci-lfs-post-checkout-hydration

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gitar-bot

gitar-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Enables Git LFS hydration in the CI-maketest and C++ CodeQL workflows by setting the checkout action's lfs input to true, resolving the missing OpenSSL source archive pointer issue. No issues found.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Important

Your trial ends in 3 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more.

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqubecloud

Copy link
Copy Markdown

@renecannao
renecannao marked this pull request as ready for review August 19, 2026 21:12
@renecannao
renecannao merged commit 1eeb678 into GH-Actions Aug 19, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant