Skip to content

feat(guardian): stabilize iterative review experiments - #532

Open
Cyoyuu wants to merge 3 commits into
mainfrom
fix/guardian-experiment-failures
Open

feat(guardian): stabilize iterative review experiments#532
Cyoyuu wants to merge 3 commits into
mainfrom
fix/guardian-experiment-failures

Conversation

@Cyoyuu

@Cyoyuu Cyoyuu commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Summary

Stabilize iterative Guardian experiments and preserve local-specification understanding across solver revision cycles.

Changes

  • validate only effective export-ignore and export-subst attributes when materializing exact Git revision snapshots
  • add explicit Codex feature controls so Guardian uses unified execution without unavailable Code Mode hosts
  • configure explorer and aggregator models independently while preserving the legacy shared-model fallback
  • persist a host-owned, snapshot-aware local-specification ledger with append-only audit events
  • process checkpoint requests along the controller-owned commit chain and report degraded, failed, and superseded reviews truthfully
  • export Guardian memory with run artifacts and add focused unit and real-run coverage

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Refactoring
  • Performance improvement
  • Tests

Testing

  • Tests pass locally

  • Added new tests for the changes

  • pytest focused Guardian/execution/sandbox suite: 81 passed, 2 deselected

  • flake8 on all changed Python files

  • isort --profile black --check-only on all changed Python files

  • black --check: all 29 changed Python files unchanged (the local process required timeout termination after reporting completion)

  • 20 real DeepSWE Guardian trials completed without launcher or Code Mode host errors

  • the broader unit tier progressed through the changed client and Guardian surfaces; two existing process-runner tests are excluded because one terminates the surrounding test process group

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

@github-actions github-actions Bot added the type/test Test-related label Aug 7, 2026
@Cyoyuu
Cyoyuu force-pushed the fix/guardian-experiment-failures branch from bb9549e to 58857e5 Compare August 7, 2026 23:07
@fishmingyu

Copy link
Copy Markdown
Member

The immediate CI and Docs failures are repository infrastructure failures, not failures in this PR. The newly enabled full-SHA Actions policy rejects setup-miniconda@v3 and setup-uv@v8.3.2 during Set up job before checkout. #534 pins every remaining floating action and adds a regression guard. Once #534 lands, this PR needs a fresh run against updated main; rerunning the old run would retain its original workflow SHA.

Cyoyuu added 3 commits August 7, 2026 18:00
Allow repositories whose archive attributes do not affect tracked paths while preserving exact revision snapshots. Resolve attributes against a private index pinned to the requested revision and cover tracked, directory, info-attribute, and integration cases.
Allow callers to enable and disable named Codex features with validation. Guardian can use this to select stable unified execution and avoid unavailable Code Mode hosts.
Maintain a host-owned local-specification ledger with snapshot-aware evidence and append-only audit events. Route explorer and aggregator models independently, process review requests along the commit chain, expose degraded analysis honestly, and export memory after solver completion.
@Cyoyuu
Cyoyuu force-pushed the fix/guardian-experiment-failures branch from 58857e5 to 48dcfa2 Compare August 8, 2026 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/test Test-related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants