chore: format the repo and enforce it in CI#87
Merged
Conversation
.prettierignore now covers generated output (SDK gen, openapi.json, models snapshot), build dirs, mdx (prettier's mdx parser is deprecated), and the curated skill content agents consume verbatim. One prettier --write over everything else, and a Format job in CI so the tree can't drift again — format:check had been failing on 1300+ files with nothing enforcing it.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…uild output CodeQL on the format pass surfaced two pre-existing defects: stripTags removed HTML tags in a single pass, so nested fragments could reassemble into a tag (incomplete-multi-character-sanitization); and the thesis repo link replaced 'github.com/' with itself. stripTags now re-strips until stable; the dead replace is gone.
The recursive form is functionally equivalent but CodeQL's incomplete-multi-character-sanitization check only recognizes the loop-until-no-change idiom as complete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #35.
bun run format:checkfailed on 1300+ files because nothing ever enforced it and.prettierignoreonly excluded one file. This PR:.prettierignoreto generated output (tooling/sdk/js/src/*/gen/,openapi.json, the models snapshot), build dirs,*.mdx(prettier's mdx parser is deprecated and can mangle JSX-in-markdown), andbackend/cli/skills/(curated templates that agents consume verbatim — format churn there is content churn)prettier --writeonce over everything else (175 files, purely mechanical)Verified after the reformat: backend suite 852 pass / 0 fail, typecheck clean, workspace + docs + landing builds all pass.