fix(cli): keep the banner glyphs aligned through yargs' help formatter#85
Merged
Conversation
The help formatter trims leading whitespace per line, which stripped the O glyph's indentation and sheared the whole OPEN SCIENCE banner. Lead each line with braille blanks (U+2800) — they render as blank cells but aren't whitespace, so the margin survives formatting in every consumer (--help, upgrade, web, uninstall).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The yargs/cliui help formatter trims leading whitespace on every line, which stripped the relative indentation out of the ANSI-shadow banner — the O's top and bottom rows shifted left and the letters sheared (the logo.ts art itself was always correct). The renderer now emits braille blanks (U+2800) for each line's leading margin: they render as blank cells but aren't whitespace, so no formatter can collapse them.
Verified by capturing
--helpoutput: all twelve banner rows keep their glyph alignment. Typecheck and CLI tests pass.