Change default Android SDK build command#269
Conversation
fb98750 to
11f9ecf
Compare
|
I think the fix in swift-android-sdk#3 should resolve the |
|
Thanks, I incorporated your changes. |
|
It looks like it is still failing, but the new log message indicates that it is using the right host toolchain: That new failure seems to be coming from: Should we be expecting a different output folder? |
89ee068 to
26548d7
Compare
|
I think the issue here is that So for example, we need to change the assumption that the test case is built at |
6eb6d0c to
21be017
Compare
4ffd4c5 to
5742b2a
Compare
| description: "Command to use when building the package with the Swift SDK for Android" | ||
| # Temporarily use native build system on Android due to https://github.com/swiftlang/swift/issues/88282 | ||
| default: "swift build --build-system native" | ||
| default: "swift build" |
- Change default build command to use 'swift build' instead of 'swift build --build-system native' (the 4/27 snapshot contains the requisite changes for Android) - Use the correct host toolchain for Android build/test - Add mention of the specific host SDK being used to build For Wasm, we want to wait until swiftlang/swift-build#1348 lands before unpinning. Co-authored-by: Marc Prud'hommeaux <mwp1@cornell.edu>
Updated default build command for Android SDK to use 'swift build' instead of 'swift build --build-system native'.
The 4/27 snapshot contains the requisite changes for Android to work.
For Wasm, we want to wait until swiftlang/swift-build#1348 lands before unpinning.