Fix build and R CMD check warnings; bump to 4.0.4#7
Open
kaneplusplus wants to merge 1 commit into
Open
Conversation
- Drop deprecated Rcpp:::LdFlags() from src/Makevars and src/Makevars.win (no longer needed since 2013; Rcpp is linked automatically via LinkingTo). - Cast .size() results to int in Rprintf calls in Params.h and Graph.h to match %d format specifier. - Remove orphan %0.2f format specifier in Cbcpgraph.cpp Rprintf with no matching argument. - Add .claude and build-artifact patterns to .Rbuildignore. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rcpp:::LdFlags()fromsrc/Makevarsandsrc/Makevars.win— unused since 2013 (Rcpp is linked automatically viaLinkingTo), and recent toolchains print a deprecation warning.-Wformatwarnings: cast.size()results tointinRprintfcalls (Params.h:122,Graph.h:186-187) so they match%d.-Wformat-insufficient-argsinCbcpgraph.cpp:58— remove an orphan%0.2fformat specifier with no matching argument.^\.claude$and build-artifact patterns to.Rbuildignoreto drop a hidden-files NOTE onR CMD check.DESCRIPTION.After these changes,
R CMD checkreportsStatus: OK(was 2 WARNINGs).Test plan
R CMD build .succeedsR CMD INSTALL bcp_4.0.4.tar.gzsucceeds_R_CHECK_FORCE_SUGGESTS_=false R CMD check bcp_4.0.4.tar.gzreturnsStatus: OKlibrary(bcp); bcp(c(rnorm(50,0,1), rnorm(50,5,1)))runs and returns abcpobjectTested locally with R 4.5.3 on macOS aarch64.
🤖 Generated with Claude Code