chore(prefetch): disable link prefetching on slow internet connections#15885
Open
Guanran928 wants to merge 1 commit into
Open
chore(prefetch): disable link prefetching on slow internet connections#15885Guanran928 wants to merge 1 commit into
Guanran928 wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: db79bd9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Guanran928
force-pushed
the
slow-connection
branch
from
37226b6 to
db79bd9
Compare
| // @ts-expect-error this isn't supported everywhere yet | ||
| if (!navigator.connection?.saveData) { | ||
| if (!navigator.connection?.saveData && !/2g/.test(navigator.connection?.effectiveType)) { | ||
| setup_preload(); |
There was a problem hiding this comment.
Maybe something for the future: if the preload could be enabled/disabled (instead of just enabled once), we could use the change event on navigator.connection (docs) to toggle it dynamically (e.g. connection suddenly becomes slow or user switches to/from a WiFi hotspot from a mobile device).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR disables link prefetching on slow Internet connections to avoid slowing down intentional page navigations network traffic.
Astro already does this: https://github.com/withastro/astro/blob/ace96ba5024129cbeb9d8e75134f4f8bdf42a57a/packages/astro/src/prefetch/index.ts#L303
You can test this by setting the network throttling to '3G' in Chrome. (it's weird, 3G shows up as
'2g'in navigator.connection.effectiveType)Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits