fix: correct relative paths on error page for a missing __data.json request#15884
Open
ATOM00blue wants to merge 1 commit into
Open
fix: correct relative paths on error page for a missing __data.json request#15884ATOM00blue wants to merge 1 commit into
__data.json request#15884ATOM00blue wants to merge 1 commit into
Conversation
…ssing __data.json request When a non-existent page is requested with the `__data.json` suffix, the suffix is stripped from the URL before routing. The error page that gets rendered computed its relative asset paths from that stripped URL, so the paths ended up one directory too shallow and failed to load the app's assets in the browser. Account for the data suffix when computing the relative path depth in both the error page renderer and `$app/paths`' `resolve`/`asset`, so the paths are resolved against the URL the browser is actually at.
🦋 Changeset detectedLatest commit: 83cf4cf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #11353
When a non-existent page is requested with the
__data.jsonsuffix (e.g./example/__data.json), the suffix is stripped from the URL before routing so that the path can be matched against the route table. The error page that is rendered for the resulting 404 then computed its relative asset paths from that stripped URL, which is one path segment shallower than the URL the browser is actually at. As a result the_app/immutable/...links (and theresolve/assethelpers from$app/paths) ended up one directory too shallow, so the error page loaded unstyled and without its scripts.For example, requesting
/example/__data.jsonproduced asset links that resolved to/example/_app/...instead of/_app/....This re-adds the data suffix when computing the relative path depth in both the error page renderer and
$app/paths'resolve/asset, so the paths are resolved against the URL the browser is actually at. Root-level requests (/__data.json) and the.html__data.jsonform are unaffected because the reconstructed path has the same segment depth as the original request.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits