Skip to content

fix: ensure base from $service-worker is available during dev#15882

Open
teemingc wants to merge 1 commit into
mainfrom
fix-service-worker-base
Open

fix: ensure base from $service-worker is available during dev#15882
teemingc wants to merge 1 commit into
mainfrom
fix-service-worker-base

Conversation

@teemingc
Copy link
Copy Markdown
Member

Noticed some service worker tests weren't being run on accident. This PR re-enables them and fixes one of them by ensuring base is exported for the dev-time $service-worker module.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@teemingc teemingc added the service worker Stuff related to service workers label May 21, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 21, 2026

🦋 Changeset detected

Latest commit: 14fc0aa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

throw new Error('This module can only be imported inside a service worker');
}

export const base = location.pathname.split('/').slice(0, -1).join('/');
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is taken from the prod version of base

const base = "location.pathname.split('/').slice(0, -1).join('/')";

@teemingc teemingc changed the title chore: ensure base from $service-worker is available during dev fix: ensure base from $service-worker is available during dev May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

service worker Stuff related to service workers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant