fix: handle about: and data: protocols when embedded in iframes/webviews#15812
Open
PranavAgarkar07 wants to merge 2 commits into
Open
fix: handle about: and data: protocols when embedded in iframes/webviews#15812PranavAgarkar07 wants to merge 2 commits into
PranavAgarkar07 wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: d7c9dee The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
35fe57e to
7281def
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #13490
Fixes: #13226
The problem
When a SvelteKit app is embedded in an
<iframe srcdoc>or loaded via adata:URL (common in webviews and embedded widgets), hydration crashes with:SvelteKit generates an inline script that runs
new URL('.', location)to compute the base path. Whenlocation.protocolisabout:(srcdoc iframes) ordata:(data URL iframes), these are non-hierarchical protocols that cannot be used as a URL base — the browser throws immediately.Two fixes
render.js— wrap the generatedbase_expressionin atry/catchso a non-hierarchical protocol falls back to the statically-known base path instead of crashing:The try/catch is future-proof — it handles any non-hierarchical protocol without enumerating them.
utils.js—is_external_urlwas treatingabout:anddata:URLs as external (their origin is"null"), causing all link clicks inside an embedded app to trigger full-page navigations instead of client-side routing:Why not #13490?
PR #13490 has a bug in the render.js change: the fallback branch returns a raw
URLobject instead of a.pathnamestring, sobasebecomes[object URL]. This PR fixes both issues correctly.Checklist
about:ordata:#13226pnpm -F @sveltejs/kit test:unit)