Skip to content

feat: warn the user when they forget to make boolean inputs optional in their form schemas#15804

Open
ottomated wants to merge 5 commits into
sveltejs:mainfrom
ottomated:non-optional-boolean-magic
Open

feat: warn the user when they forget to make boolean inputs optional in their form schemas#15804
ottomated wants to merge 5 commits into
sveltejs:mainfrom
ottomated:non-optional-boolean-magic

Conversation

@ottomated
Copy link
Copy Markdown
Contributor

closes #15785
closes #15786

Through typescript trickery, prevent form schemas from containing non-optional booleans, i.e.:

// Not allowed:
form(v.object({
  checkbox: v.boolean(),
}));

// Allowed:
form(v.object({
  checkbox: v.optional(v.boolean(), false)
}));

This prevents the pitfall of forgetting that <input type="checkbox"> elements don't send a false value when they're unchecked.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 6, 2026

🦋 Changeset detected

Latest commit: 63d3739

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link
Copy Markdown

@teemingc teemingc added the forms Stuff relating to forms and form actions label May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

forms Stuff relating to forms and form actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[2.59.0] Cannot submit form with unchecked checkbox

2 participants