Skip to content

Fix #13 - Ensure time is always encoded in ms and fix 32 bit Time call#14

Open
ChrisBove wants to merge 1 commit into
suyash:masterfrom
ChrisBove:cbove/fix-timestamp
Open

Fix #13 - Ensure time is always encoded in ms and fix 32 bit Time call#14
ChrisBove wants to merge 1 commit into
suyash:masterfrom
ChrisBove:cbove/fix-timestamp

Conversation

@ChrisBove

Copy link
Copy Markdown

This addresses #13.

Changes

  • Change all timing calls to use chrono time points to ensure ms units (not seconds) are always encoded as the timestamp portion
  • Fix problems using time_t on 32 bit systems by explicitly making this an int64_t. This is a different approach than fix for 32-bits #9.

Questions

  • In hindsight, for backwards compatibility, it would probably be good to keep all the original function signatures using time_t and just convert to ms with from_time_t. Let me know if I should make that change.

…ll to Time(ulid)

- Change all timing calls to use chrono time points to ensure ms units (not seconds) are always encoded as the timestamp portion
- Fix problems using time_t on 32 bit systems by explicitly making this an int64_t
bdraco added a commit to Bluetooth-Devices/ulid-transform that referenced this pull request Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant