Skip to content

Navbarchanges #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MatthewBorda wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Navbarchanges #8

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
003f534
Poem navbar
MatthewBorda Nov 5, 2016
cc061d0
Added navbar
MatthewBorda Nov 5, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
96 changes: 94 additions & 2 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,105 @@
<![endif]-->
<nav class="navbar navbar-inverse navbar-fixed-top" role="navigation">
<div class="container">
<div class="navbar-header">
<!-- <div class="navbar-header">
<button type="button" class="navbar-toggle collapsed" data-toggle="collapse" data-target="#navbar" aria-expanded="false" aria-controls="navbar">
<span class="sr-only">Toggle navigation</span>
<span class="icon-bar"></span>
<span class="icon-bar"></span>
<span class="icon-bar"></span>
</button>
</button> -->
<ul class = "nav nav-tabs">
<li role="presentation" class="active"><a href="#">Home</a></li>
<li role="presentation"><a href="#">About</a></li>
<li class="dropdown">
<a href="#" class="dropdown-toggle" data-toggle="dropdown" role="button" aria-haspopup="true" aria-expanded="false">Find a Poem <span class="caret"></span></a>

@MatthewBorda MatthewBorda Nov 26, 2016

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be all replaced with something less hardcoded. I would recommend a plugin such as this one: http://mmenu.frebsite.nl/. We had discussed making this menus and submenus contain dynamic content that is based off of either counts from the API we used or popularity of the site users. This plugin contains the ability to dynamically add menu options and has a mobile first format to it. Overall, I think this code is too clunky to be maintained. This should be used only as a proof of concept.

<ul class="dropdown-menu">
<li><p>Filter By</p></li>
<li><form class="navbar-form" role="search">
<div class="input-group">
<input type="text" class="form-control" placeholder="Search" name="poemMainSearch">
<div class="input-group-btn">
<button class="btn btn-default" type="submit"><i class="glyphicon glyphicon-search"></i></button>
</div>
</div>
</form>
</li>

<li class="dropdown">
<a href="#" class="dropdown-toggle" data-toggle="dropdown" role="button" aria-haspopup="true" aria-expanded="false">Popular Poetry Type<span class="caret"></span></a>
<ul class="dropdown-menu">
<li><a href="#">Place Holder 1</a></li>
<li><a href="#">Place Holder 2</a></li>
<li><a href="#">Place Holder 3</a></li>
</ul>
</li>
<li class="dropdown">
<a href="#" class="dropdown-toggle" data-toggle="dropdown" role="button" aria-haspopup="true" aria-expanded="false">Popular Poetry Movements<span class="caret"></span></a>
<ul class="dropdown-menu">
<li><a href="#">Place Holder 1</a></li>
<li><a href="#">Place Holder 2</a></li>
<li><a href="#">Place Holder 3</a></li>
</ul>
</li>
<li class="dropdown">
<a href="#" class="dropdown-toggle" data-toggle="dropdown" role="button" aria-haspopup="true" aria-expanded="false">Popular Poetry Schools<span class="caret"></span></a>
<ul class="dropdown-menu">
<li><a href="#">Place Holder 1</a></li>
<li><a href="#">Place Holder 2</a></li>
<li><a href="#">Place Holder 3</a></li>
</ul>
</li>

<li class="dropdown">
<a href="#" class="dropdown-toggle" data-toggle="dropdown" role="button" aria-haspopup="true" aria-expanded="false">Popular Poetry Genre<span class="caret"></span></a>
<ul class="dropdown-menu">
<li><a href="#">Place Holder 1</a></li>
<li><a href="#">Place Holder 2</a></li>
<li><a href="#">Place Holder 3</a></li>
</ul>
</li>

<li class="dropdown">
<a href="#" class="dropdown-toggle" data-toggle="dropdown" role="button" aria-haspopup="true" aria-expanded="false">Poet Country of Origin<span class="caret"></span></a>
<ul class="dropdown-menu">
<li><a href="#">Place Holder 1</a></li>
<li><a href="#">Place Holder 2</a></li>
<li><a href="#">Place Holder 3</a></li>
</ul>
</li>

<li class="dropdown">
<a href="#" class="dropdown-toggle" data-toggle="dropdown" role="button" aria-haspopup="true" aria-expanded="false">Poem Language<span class="caret"></span></a>
<ul class="dropdown-menu">
<li><a href="#">Place Holder 1</a></li>
<li><a href="#">Place Holder 2</a></li>
<li><a href="#">Place Holder 3</a></li>
</ul>
</li>

<li class="dropdown">
<a href="#" class="dropdown-toggle" data-toggle="dropdown" role="button" aria-haspopup="true" aria-expanded="false">Poem Time Frame<span class="caret"></span></a>
<ul class="dropdown-menu">
<li><a href="#">Place Holder 1</a></li>
<li><a href="#">Place Holder 2</a></li>
<li><a href="#">Place Holder 3</a></li>
</ul>
</li>
</ul>
</li>
<li class="dropdown">
<a href="#" class="dropdown-toggle" data-toggle="dropdown" role="button" aria-haspopup="true" aria-expanded="false">Find a Drink <span class="caret"></span></a>
<ul class="dropdown-menu">
<li><a href="#">Action</a></li>
<li><a href="#">Another action</a></li>
<li><a href="#">Something else here</a></li>
<li role="separator" class="divider"></li>
<li><a href="#">Separated link</a></li>
<li role="separator" class="divider"></li>
<li><a href="#">One more separated link</a></li>
</ul>
</li>
</ul>
<a class="navbar-brand" href="#">Poet's Bar</a>
</div>
<div id="navbar" class="navbar-collapse collapse">
Expand Down