Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from setuptools import setup, find_packages

VERSION = "1.5.22"
VERSION = "1.5.23"

with open("requirements.txt") as f:
requirements = f.read().splitlines()
Expand Down
8 changes: 6 additions & 2 deletions surge/api_resource.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ def _base_request(cls,
elif method == "delete":
response = requests.delete(url,
auth=(api_key_to_use, ""),
params=params,
**header_kwargs)

elif method == "patch":
Expand Down Expand Up @@ -141,6 +142,9 @@ def patch(cls, api_endpoint, params=None, api_key=None):
api_key=api_key)

@classmethod
def delete_request(cls, api_endpoint, api_key=None):
def delete_request(cls, api_endpoint, api_key=None, params=None):
method = "delete"
return cls._base_request(method, api_endpoint, api_key=api_key)
return cls._base_request(method,
api_endpoint,
params=params,
api_key=api_key)
16 changes: 16 additions & 0 deletions tests/test_api_resource.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,3 +71,19 @@ def test_get_passed_in_file():
def test_print_attrs():
a1 = APIResource(id="ABC1234").print_attrs()
assert a1 == 'id="ABC1234"'


def test_delete_request_forwards_params():
with mock.patch.object(requests, "delete") as mock_request:
mock_request.return_value = mock.MagicMock()
APIResource._base_request(
"delete",
surge.api_resource.PROJECTS_ENDPOINT,
params={"foo": "bar"},
api_key="passed_api_key",
)
mock_request.assert_called_once_with(
"https://app.surgehq.ai/api/projects",
auth=("passed_api_key", ""),
params={"foo": "bar"},
)
Loading