bindings/rust: expose std as a Cargo feature - #287
Open
rnzorgani-ledger wants to merge 1 commit into
Open
Conversation
Currently std is inferred purely from the target triple in build.rs, so a consumer building for a hosted target that happens to look std-capable (e.g. powerpc-unknown-linux-gnu firmware) cannot opt out of std and the threadpool dependency. Make `std` a real, default-on Cargo feature that gates the `threadpool` dependency, and fold it into the build.rs no_std detection so `--no-default-features` (or BLST_TEST_NO_STD) yields a genuine no_std build. Target-based detection and the wasm32/unknown auto no-threads behaviour are preserved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std is currently inferred purely from the target triple in build.rs, so a consumer building for a hosted-looking target cannot opt out of std and the threadpool dependency. This makes
stda real, default-on Cargo feature gatingthreadpool, and folds it into build.rs no_std detection so--no-default-features(or BLST_TEST_NO_STD) yields a genuine no_std build. Target-based detection and the wasm32/unknown auto no-threads behaviour are preserved.