Default to light theme for first-time visitors#209
Merged
Conversation
Visitors with no stored preference now get light mode instead of dark. Explicit picker choices and the auto (system preference) option are unchanged.
Contributor
Preview Deployment
Commit: |
Contributor
Lighthouse Results
|
Contributor
E2E Test Results✅ Tests success Ran against: https://pr-209-superfly-sprites-docs.fly.dev |
The ThemeSwitcher had its own fallback of 'dark' for visitors with no stored preference, so the picker icon showed the moon while the page rendered light.
kcmartin
added
the
sprite-refresh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now the docs force dark mode on anyone who's never touched the theme picker. This flips that default to light, in keeping with bringing Sprites under Fly.io branding.
Everything else works the same: picking light or dark explicitly still sticks, and "auto" still follows your system preference. Folks who already chose a theme keep their choice, since it's stored in localStorage.
Also updates the CLAUDE.md styling note to match our change.