fix: R_FindPlane aborts on visplane pool exhaustion - #162
Open
VedantMadane wants to merge 1 commit into
Open
Conversation
- R_FindPlane calls i_error! on visplane pool exhaustion instead of returning null Fixes sunsided#117 Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| @@ -547,7 +548,7 @@ pub extern "C" fn R_ClearPlanes() { | |||
| /// and light level 0. | |||
| /// | |||
| /// Returns a null pointer if the visplane pool (128 entries) is exhausted | |||
There was a problem hiding this comment.
WARNING: Stale doc comment — function no longer returns null on exhaustion
The function now aborts via i_error! when the visplane pool is exhausted, but this doc comment still claims it returns a null pointer. Update to reflect the actual behavior (e.g., "Aborts via i_error! if the visplane pool (128 entries) is exhausted").
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (1 file)
Fix these issues in Kilo Cloud Reviewed by kimi-k2.6 · Input: 85.3K · Output: 12.1K · Cached: 276.1K |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
R_FindPlane aborts on visplane pool exhaustion
Changes
Fixes #117