Reuse parameter definitions and docstrings in thermal emission module models - #297
Open
samaloney wants to merge 3 commits into
Open
Reuse parameter definitions and docstrings in thermal emission module models#297samaloney wants to merge 3 commits into
samaloney wants to merge 3 commits into
Conversation
* Fix now included doc strings
samaloney
changed the title
samaloney
commented
Aug 6, 2026
|
|
||
|
|
||
| def _initialize_abundances(abundances: Column) -> tuple[float]: | ||
| def _initialize_abundances(abundances: Column) -> tuple[float, ...]: |
Member
Author
There was a problem hiding this comment.
Not sure where the type annotation came from but updated the annotation and code to keep the language server happy
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Currently we essentially copy paste ~90 lines of parameter definitions across the model in the thermal module. This PR shares a single definition of the parameter across them all.
Also found and fixed a bug that meant the class docs were actually None if you did
help(LimeEimmsion)etc and then also fixed the docstring so they work in the doc build.AI Assistance Disclosure
AI tools were used for: