Make channels time snapshots via Channel.at(obstime)#208
Open
nabobalis wants to merge 2 commits into
Open
Conversation
nabobalis
force-pushed
the
channel-obstime-snapshot
branch
from
c34f987 to
f166e0a
Compare
nabobalis
changed the title
nabobalis
force-pushed
the
channel-obstime-snapshot
branch
2 times, most recently
from
3e1ab7e to
0927782
Compare
nabobalis
force-pushed
the
channel-obstime-snapshot
branch
from
0927782 to
2ff4d5a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A channel instance now represents the instrument at one time. AbstractChannel.at(obstime) returns a time-bound copy and is the only way time enters a response calculation; effective_area() and wavelength_response() no longer accept obstime, and neither do get_temperature_response() or SourceSpectra.temperature_response(). An unbound channel (or at(None)) never evaluates degradation, so degradation() implementations may require a time.
Why: consumers such as emission models call channel methods without a time argument; threading obstime through every coupling function forced per-function adapter proxies and broke caches keyed on channel identity. Binding time on the channel removes the dual code path entirely.
BREAKING CHANGE: obstime keyword removed from wavelength_response, effective_area, get_temperature_response and
SourceSpectra.temperature_response; use channel.at(obstime) instead.