Add Antigravity advisory dogfood canary#666
Conversation
|
Warning Review limit reached
More reviews will be available in 35 minutes and 29 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Local review: LGTM. I reviewed the Antigravity advisory scenario wiring, route-policy coverage, readiness docs, worktree-mutation fail-closed guard, and classifier behavior. CI is green, CodeRabbit only reported rate limiting, and local validation passed: node --test tests/relay-review/scripts/invoke-reviewer.test.js; node --test tests/relay-dispatch/scripts/live-dogfood.test.js tests/relay-dispatch/scripts/docs-defaults.test.js; node --test tests/skills-lint/scripts/*.test.js; git diff --check. Live evidence: antigravity-advisory currently fails closed with timeout plus .antigravitycli worktree mutation, with no false promotion. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 269463775a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const afterStatus = readWorktreeStatus(repoPath); | ||
| if (afterStatus === beforeStatus) return ""; |
There was a problem hiding this comment.
When the review checkout is already dirty, comparing only git status --porcelain text lets Antigravity mutate an existing dirty path without being caught: for example, if README.md is already M README.md or the prompt file is an untracked ?? prompt.md, edits to that same file leave afterStatus === beforeStatus and the adapter accepts the structured result despite violating read-only review mode. This can occur for direct adapter use or any review checkout with pre-existing dirty artifacts, so the guard should either require a clean tree before invocation or compare content fingerprints/diffs as well as status rows.
Useful? React with 👍 / 👎.
1 participant
Closes #625
Summary
antigravity-advisorylive dogfood scenario and route-policy coverageLive evidence
RELAY_HOME=$(mktemp -d) node skills/relay-dispatch/scripts/live-dogfood.js --repo . --scenario antigravity-advisory --antigravity-review-timeout 30s --command-timeout-ms 70000 --json --markdownantigravity-advisory->failagy --prompttimed out after 30s and created.antigravitycli/, so relay records a clear non-success blocker without promotionValidation
node --test tests/relay-review/scripts/invoke-reviewer.test.jsnode --test tests/relay-dispatch/scripts/live-dogfood.test.js tests/relay-dispatch/scripts/docs-defaults.test.jsnode --test tests/skills-lint/scripts/*.test.jsgit diff --check