feat(spec): add report-first capability grill workflow#182
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
Walkthrough이 PR은 spec-grill의 인자 기반 모드에서 자연어 의도 라우팅으로 전환하고, extract-signals를 증거 그룹화 기반 수집기로 확장하여, spec-system-map을 capability 경계 후보 핸드오프 브릿지로 확립합니다. ChangesSpecification Skill & Contract Updates
Evidence-Grouped Capability Candidate Collection
Artifact Documentation & Dogfooding
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related issues
Possibly related PRs
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cd2c659e83
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const slug = slugifyCandidate(name); | ||
| if (!slug || !signal) continue; | ||
| const signals = merged.get(slug) || []; | ||
| if (!signals.includes(signal)) signals.push(signal); | ||
| merged.set(slug, signals); |
There was a problem hiding this comment.
When a commit scope or directory name contains characters that slugifyCandidate rewrites (for example conventional scopes like api/auth, which the parser explicitly accepts), this evidence path creates a second slugged candidate instead of merging with the raw candidate already added from scopeCounts. In a repo with two api/auth commits, extractSignals() now returns both api/auth and api-auth, splitting the same evidence across duplicate raw candidates; normalize the keys used for dirNames/scopeCounts and evidenceCandidates consistently before lookup/set.
Useful? React with 👍 / 👎.
1 participant
Summary
spec-grillreport-first with natural-language intent routing instead of argument memorization.spec-system-mapas the handoff between charter direction and capability grilling.extract-signals.jsto group evidence from README, system map, skills, scripts, docs, tests, source surfaces, and commit scopes.spec/system-map.mdandspec/capabilities.mdto reflect the new workflow boundaries.Validation
node --test skills/spec-grill/scripts/extract-signals.test.jsfind skills -name '*.test.js' ! -name '*.integration.test.js' -print0 | xargs -0 node --testnode skills/dev-backlog/scripts/capabilities-doctor.js --capabilities spec/capabilities.md --strictnode skills/dev-backlog/scripts/component-lint.js --sprints-dir backlog/sprints --capabilities spec/capabilities.mdnode skills/dev-backlog/scripts/objectives-check.js --sprints-dir backlog/sprints --charter spec/charter.mdbash skills/dev-backlog/scripts/smoke-test.shgit diff --checkRefs #176
Closes #177
Closes #178
Closes #179
Closes #180
Closes #181
Summary by CodeRabbit
릴리스 노트
Documentation
Tests