Add MIGRATE_MODULE_PROPAGATE_END event to propagate module commands at the end of slot migration#472
Open
sundb wants to merge 3 commits into
Open
Add MIGRATE_MODULE_PROPAGATE_END event to propagate module commands at the end of slot migration#472sundb wants to merge 3 commits into
sundb wants to merge 3 commits into
Conversation
…t the end of slot migration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
During atomic slot migration (ASM), modules can already propagate commands to
the destination node at the beginning of the migration via the
REDISMODULE_SUBEVENT_CLUSTER_SLOT_MIGRATION_MIGRATE_MODULE_PROPAGATEevent andthe
RM_ClusterPropagateForSlotMigration()API. Those commands are delivered asthe first part of the migration stream, before the slot snapshot.
There was no equivalent hook to propagate commands at the end of the
migration, which some modules need to keep their own state consistent on the
destination side.
What this PR does
Adds a new sub-event
REDISMODULE_SUBEVENT_CLUSTER_SLOT_MIGRATION_MIGRATE_MODULE_PROPAGATE_END,fired on the source node at the very end of the migration — right before the
STREAM-EOFis sent to the destination. Modules use the sameRM_ClusterPropagateForSlotMigration()API to enqueue commands; they aredelivered as the last part of the migration stream.
MIGRATE_MODULE_PROPAGATEMIGRATE_MODULE_PROPAGATE_ENDSTREAM-EOF