fix(security): remove hardcoded backend IP and enforce secure transport#6574
Open
karthik-dev56 wants to merge 1 commit intosugarlabs:masterfrom
Open
fix(security): remove hardcoded backend IP and enforce secure transport#6574karthik-dev56 wants to merge 1 commit intosugarlabs:masterfrom
karthik-dev56 wants to merge 1 commit intosugarlabs:masterfrom
Conversation
github-actions
bot
added
bug fix
Contributor
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
karthik-dev56
force-pushed
the
fix-hardCoded-BackendIP-HTTPPusage
branch
from
2e765d1 to
d8fc551
Compare
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
Author
|
Hey @walterbender please have a look when u have time |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
Author
|
@vanshika2720 this protocol dynamically is the safe approach. If anyone deploys Music Blocks on an https://server, fetching from a hardcoded http:// API would be blocked by the browser for Mixed Content. It ensures it works on both localhost and deployments |
vanshika2720
approved these changes
Apr 12, 2026
Contributor
|
#5919 duplicate pr ( we are actively reviewing pr 5919 ) and even had discussion today in the meet for 5919 |
Contributor
|
hey @Ashutoshx7 where does this meet link comes , I can't see it in the channel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the hardcoded IP address with a dynamic hostname pattern or an environment-based configuration (similar to how aidebugger.js handles it!).
Enforce https:// for all backend routing to ensure the data is transmitted safely over the network.