Fix/issue 6563 help lazyload#6567
Open
Tomeshwari-02 wants to merge 4 commits intosugarlabs:masterfrom
Open
Conversation
github-actions
bot
added
bug fix
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
Author
|
@walterbender Hi, could you please review this PR when you have some time? Thank you! |
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
Summary
Lazy-load
widgets/helpbefore opening the aux pie menu help widget so right-click help works even when the toolbar help has not been opened first.Why
HelpWidgetwas already loaded for the toolbar path, but the aux pie menu path still assumed it was present. That causedHelpWidget is not definedwhen help was opened directly from a block context menu.Validation
node --check js/piemenus.jsnode --check js/__tests__/piemenus.test.js