Skip to content

feat: Improve keyboard focus visibility for accessibility#6448

Open
abdulazees1111s wants to merge 4 commits intosugarlabs:masterfrom
abdulazees1111s:improve-focus-accessibility
Open

feat: Improve keyboard focus visibility for accessibility#6448
abdulazees1111s wants to merge 4 commits intosugarlabs:masterfrom
abdulazees1111s:improve-focus-accessibility

Conversation

@abdulazees1111s
Copy link
Copy Markdown

@abdulazees1111s abdulazees1111s commented Mar 30, 2026

Summary

Improved keyboard focus visibility across UI components to enhance accessibility.

Changes Made

  • Added global focus-visible styles
  • Improved focus styles for toolbar buttons
  • Enhanced dropdown focus visibility
  • Improved palette item focus contrast

Accessibility

Improves usability for keyboard users and users with accessibility needs.

Testing

  • Verified focus visibility using keyboard navigation (Tab key)
  • Tested toolbar, dropdown, and palette navigation

PR Category

  • Accessibility
  • Feature
  • Bug Fix

@abdulazees1111s
Copy link
Copy Markdown
Author

Hi! I created a PR to improve keyboard focus visibility for accessibility. Could someone review it? Thanks!

@github-actions
Copy link
Copy Markdown
Contributor

❌ Some Jest tests failed. Please check the logs and fix the issues before merging.

Failed Tests:

toolbar.test.js

@github-actions github-actions bot added bug fix Fixes a bug or incorrect behavior size/XXL XXL: 1000+ lines changed area/javascript Changes to JS source files area/i18n Changes to localization files area/core Changes to core app entry files labels Mar 30, 2026
Copy link
Copy Markdown
Contributor

@kartikktripathi kartikktripathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to have a lot of unrelated changes. Please check and remove them before a maintainer takes a look.

Copy link
Copy Markdown
Contributor

@vanshika2720 vanshika2720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abdulazees1111s Please split this PR into smaller ones:

PR 1: Accessibility (focus styles only)
PR 2: Tamil + language additions
PR 3: Translation updates (ta.json)
PR 4 (optional): Toolbar cleanup

@Ashutoshx7
Copy link
Copy Markdown
Contributor

any updates on this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/core Changes to core app entry files area/i18n Changes to localization files area/javascript Changes to JS source files bug fix Fixes a bug or incorrect behavior size/XXL XXL: 1000+ lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants