Fix: Improve palette text contrast across light, dark, and high-contrast themesFix palette text contrast#6440
Open
abdulazees1111s wants to merge 3 commits intosugarlabs:masterfrom
Open
Conversation
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Author
|
Hi! This is my first contribution. I’ve addressed the UI contrast issue across themes. |
Contributor
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
Contributor
|
hey, i think this is totally different problem. the inconsistency happens sometimes when it doesn't load properly, but right now the in the master it works good. |
Contributor
|
hey @abdulazees1111s , Thanks for the accessibility improvements ... I noticed a few things that should be addressed before merging this :
Once these are sorted out, I’d feel much more comfortable approving the PR. |
Contributor
|
hy take a look everything is faling can't start reviewing at this stage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improved text visibility and contrast for palette items across light, dark, and high-contrast themes.
Problem
Palette items (e.g., "Flow") had poor contrast in different themes:
This made the UI difficult to read and reduced accessibility.
Changes Made
Updated text color for palette items to ensure sufficient contrast
Improved background color for hover and selected states
Added theme-specific styling for:
Ensured consistent readability across all modes
Accessibility
These changes improve usability for users with:
Testing
Screenshots
** Before
**After
1.Light Mode
2.Dark Mode
3.High Contrast Mode
Issue
Fixes #6439
PR Category