Lazy-load performanceTracker only when performance mode is enabled us…#6434
Open
swapnachoudhary43 wants to merge 4 commits intosugarlabs:masterfrom
Open
Lazy-load performanceTracker only when performance mode is enabled us…#6434swapnachoudhary43 wants to merge 4 commits intosugarlabs:masterfrom
swapnachoudhary43 wants to merge 4 commits intosugarlabs:masterfrom
Conversation
Contributor
Author
|
Implemented lazy-loading of performanceTracker (#6418).
|
Contributor
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
…ire and bare performanceTracker references
Contributor
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
Moved constants to logoconstants.js to resolve circular dependency.
Contributor
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
Ashutoshx7
approved these changes
Apr 8, 2026
Contributor
|
resolve merge conflict |
Contributor
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
Contributor
|
hy merge conflict again and jest faling |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #6418 by implementing lazy-loading of
performanceTrackerto improve application startup performance.Changes included:
performanceTrackerin activity.js so it no longer loads for all users at startup.typeof performanceTracker !== "undefined"checks.Testing performed:
Normal mode (no ?performance=true):
Performance mode (?performance=true):
Outcome:
Normal users experience faster startup.
Performance mode users retain full instrumentation functionality.
Clean code with no leftover typeof performanceTracker checks ensures maintainability.
Bug Fix
Performance
Note: synthutils.test.js is also failing but this is a pre-existing issue on master branch, completely unrelated to this PR. All other 123 test suites pass including logo.test.js.