Skip to content

Possibility to set client config filename to download#198

Open
rkul wants to merge 3 commits into
subspacecommunity:masterfrom
rkul:client-config-filename
Open

Possibility to set client config filename to download#198
rkul wants to merge 3 commits into
subspacecommunity:masterfrom
rkul:client-config-filename

Conversation

@rkul

@rkul rkul commented Jun 25, 2021

Copy link
Copy Markdown

to: @subspacecommunity/subspace-maintainers
resolves: #118

Background

There is no way to change config filename, which clients download from UI

Changes

  • Add possibility to set client config filename to download
  • Update connection how-to for Linux devices

image

Testing

  1. Login to the subspace
  2. Add new device
  3. Download config for the newly created device
  4. Download config for the previously created device (before upgrade)

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gchamon

gchamon commented Jun 30, 2021

Copy link
Copy Markdown

@rkul can't you just move the file, changing the name? or changing the name when downloading the file?
ex:
sudo mv ~/Downloads/wg0.conf /etc/wireguard/wg_example.conf

@rkul

rkul commented Jun 30, 2021

Copy link
Copy Markdown
Author

@gchamon for sure I can do that, but when I have multiple WG setups for different environments it is a little bit easier to [re]import a config with appropriate name

@gchamon

gchamon commented Jun 30, 2021

Copy link
Copy Markdown

I understand. Do you think it would be better to customize the connect message using the filename config? Strip the .conf from the filename var and put it in the message.

Another issue, is that it opens for misconfiguration. Filename must abide to linux naming rules. Do you think we should check that?

@rkul

rkul commented Jul 1, 2021

Copy link
Copy Markdown
Author

@gchamon it would be nice to have customized connect message. As for second point, please check my comment here #118 (comment)
Actually there is no strict rules, user is able to rename the network device https://systemd.io/PREDICTABLE_INTERFACE_NAMES/ There is always a possibility for misconfiguration, but the default value wg0.conf should help to avoid most of the issues.

@rkul

rkul commented Jul 1, 2021

Copy link
Copy Markdown
Author

^[a-zA-Z0-9_=+.-]{1,15}$ should be enough to check interface name

@mrnonz

mrnonz commented Nov 10, 2021

Copy link
Copy Markdown

I think this feature so useful.

Can't wait to new release!

@mrnonz mrnonz mentioned this pull request Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a new flag to change wireguard's device name.

3 participants