Skip to content

the old and new functionality for generating BTC addresses was separated - #51

Merged
AleksDemian merged 3 commits into
masterfrom
separate-deriver
Oct 28, 2025
Merged

the old and new functionality for generating BTC addresses was separated#51
AleksDemian merged 3 commits into
masterfrom
separate-deriver

Conversation

@AleksDemian

@AleksDemian AleksDemian commented Oct 27, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • The new generation of BTC addresses using hmac remained in BTCDepositAddressDeriver
  • The old taproot address generation was moved to LegacyBTCDepositAddressDeriver.
  • The tests have also changed accordingly. The old tests have been moved to Legacy.
  • Added Ownable to BTCDepositAddressDeriver because it will be an independent contract.

@AleksDemian
AleksDemian requested a review from szhygulin October 27, 2025 09:04
@AleksDemian AleksDemian self-assigned this Oct 27, 2025
szhygulin
szhygulin requested changes Oct 27, 2025
View reviewed changes

@szhygulin szhygulin left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still there are some functions in a new Deriver that can be deleted, e.g. mulPubkey, addPubkey, computeTaprootKeyNoScript, etc.

@AleksDemian

AleksDemian commented Oct 27, 2025

Copy link
Copy Markdown
Contributor Author

Still there are some functions in a new Deriver that can be deleted, e.g. mulPubkey, addPubkey, computeTaprootKeyNoScript, etc.

These functions cannot be deleted. They are used in the deriveChildPubkeyBip32 and deriveReceivingAddressFromIndex functions.

@AleksDemian
AleksDemian requested a review from szhygulin October 27, 2025 14:26
szhygulin
szhygulin approved these changes Oct 28, 2025
View reviewed changes

@szhygulin szhygulin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right!

@AleksDemian
AleksDemian merged commit 5b9c73a into master Oct 28, 2025
1 check passed
@AleksDemian
AleksDemian deleted the separate-deriver branch October 28, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@szhygulin szhygulin szhygulin approved these changes

Assignees

@AleksDemian AleksDemian

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AleksDemian @szhygulin