Skip to content

fix: set --page-load-timeout maximum value to 3600 (1 hour) #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stanislaw merged 1 commit into from
Jun 21, 2026
Merged

fix: set --page-load-timeout maximum value to 3600 (1 hour) #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions html2pdf4doc/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,8 +566,8 @@ def _main() -> None:
)
command_parser_print.add_argument(
"--page-load-timeout",
# 10 minutes should be enough to print even the largest documents.
type=IntRange(0, 10 * 60),
# 60 minutes should be enough to print even the largest documents.
type=IntRange(0, 60 * 60),
default=2 * 60,
help=(
"How long shall html2pdf4doc Python driver wait while the "
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/06_page_load_timeout_validation/test.itest
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
RUN: %expect_exit 2 %html2pdf print --page-load-timeout 1000000 %S/index1.html %S/Output/index1.pdf 2>&1 | filecheck %s

CHECK: {{.*}} print: error: argument --page-load-timeout: Must be an integer in the range [0, 600].
CHECK: {{.*}} print: error: argument --page-load-timeout: Must be an integer in the range [0, 3600].
Loading