This repository was archived by the owner on Feb 14, 2023. It is now read-only.
Return entities as endpoints#22
Open
kasisnu wants to merge 1 commit into
Open
Conversation
|
|
||
| func newEntity(host string, port int) *entity { | ||
| return &entity{ | ||
| func NewEntity(host string, port int) *Entity { |
Contributor
There was a problem hiding this comment.
Is there a reason this method is exported?
Author
There was a problem hiding this comment.
good catch, that wasn't needed.
Author
|
@paulmach Updated! |
Author
|
pings @paulmach for follow up. 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #19