Align auth response CSP and add Strava sign-in fallback#8
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Strava authentication flow by applying security headers to dynamic server responses and adding a non-JavaScript form fallback for connecting with Strava.
Changes:
- Adds a SvelteKit server hook to set security headers, including CSP, on resolved responses.
- Composes the new security-header hook with the existing Auth.js handler.
- Replaces the click-only Strava button with a form-backed submit button that still calls
signIn('strava')when JavaScript is available.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/hooks.server.ts |
Adds CSP and other security headers to dynamic responses while preserving auth handling. |
src/lib/components/sidebar/ConnectPanel.svelte |
Adds a form-based Strava sign-in fallback around the existing client-side sign-in behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+5
to
+12
| const contentSecurityPolicy = [ | ||
| "default-src 'self' blob: data: https://*.basemaps.cartocdn.com", | ||
| "font-src 'self'", | ||
| "img-src 'self' https://*.basemaps.cartocdn.com data: blob:", | ||
| "object-src 'none'", | ||
| "script-src 'self' 'unsafe-inline' https://static.cloudflareinsights.com blob: data:", | ||
| "style-src 'self' 'unsafe-inline'" | ||
| ].join('; '); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The “Connect with Strava” flow fails with CSP blocking inline script execution, followed by a client-side error from missing auth navigation. This PR makes dynamic auth responses honor the same CSP as static pages and provides a reliable, keyboard-accessible sign-in fallback.
signIn('strava')when JS is available.