feat(WebAuthn): allow multiple credentials per user#29
Open
nsatragno wants to merge 3 commits into
Open
Conversation
| return res.status(403).json({ | ||
| 'status': 'failed', | ||
| 'message': `${usernameField} ${username} already exists`, | ||
| let user = await this.store.get(username) |
Contributor
There was a problem hiding this comment.
IIRC I think level will throw if something doesn't exist in the DB
Contributor
Author
There was a problem hiding this comment.
Looks like that's being caught by the adapter
Contributor
|
I think this is conflicting due to me merging #24; otherwise the way you're storing the many credentials is straight forward and looks good to me. |
This change allows users to associate multiple credentials to their account. When performing assertions, all the credentials are sent on the `allowList`. When registering a new credential, existing credentials are sent on the `excludeList`. Updated the example to show all the credentials associated to a user. This change is not backwards compatible.
nsatragno
force-pushed
the
multiple_users
branch
from
9538886 to
98c0782
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #29 +/- ##
===========================================
+ Coverage 12.66% 24.87% +12.20%
===========================================
Files 5 5
Lines 387 386 -1
===========================================
+ Hits 49 96 +47
+ Misses 338 290 -48 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nsatragno
commented
Jan 27, 2020
Contributor
Author
nsatragno
left a comment
nsatragno
left a comment
There was a problem hiding this comment.
I rebased this patch, PTAL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows users to associate multiple credentials to their
account. When performing assertions, all the credentials are sent on the
allowList. When registering a new credential, existing credentials aresent on the
excludeList.Updated the example to show all the credentials associated to a user.
This change is not backwards compatible.
Depends on #24
Fixes #12