rfc(indexer): Do not fail query when writing to cache#57
Open
alanshaw wants to merge 2 commits into
Open
Conversation
alanshaw
changed the title
volmedo
approved these changes
Jun 16, 2025
volmedo
left a comment
volmedo
left a comment
There was a problem hiding this comment.
I agree with this. Given that the indexer is essentially a cache in front of IPNI there is no point in it failing the request completely if the data has already been fetched.
For now, I think the easiest way to avoid the issue going unnoticed is reporting the error to Sentry.
hannahhoward
approved these changes
Jun 16, 2025
hannahhoward
left a comment
hannahhoward
left a comment
Member
There was a problem hiding this comment.
LGTM just get it to sentry
This was referenced Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposes returning query data to the client even if cache write operation fails.
📚 Preview