Fix: Collapsing Team Cards in Prod#44
Open
JessieWooten wants to merge 2 commits into
Open
Conversation
Collaborator
|
Nice! So what you did to figure this out was just comparing the classes in the live version with the local version.. You know.. I don't know why I didn't think to do that.. 🤦🏾♂️ Good job catching this though! |
Author
Yep. The give away was when I saw absolute positioning used in the .scss file. From there I realized the column containers were still respecting text content height and I knew what was happening. Absolute position is notorious for doing exactly this haha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes collapsing team member cards in production.
CSS Specificity Issue
The root cause of the problem was css specificity on
div.card.card-front. When ran locally, the.cardclass takes precedent applyingposition: relativeto the element. Once the project runs in prod, however,.card-frontwins..card-frontappliesposition: absolutecausing the element to be removed from the document flow and its height/width to no longer be reflected in the parent. The result is the parent.flip-card-innerelement's height and width collapsing down to the remaining text nodes.Running Locally
Running on Firebase