fix(JATS): Don't duplicate footnote content in abstract - #969
Open
rgieseke wants to merge 6 commits into
Open
Conversation
Previously all `<p>`s would be rendered. With footnotes a paragraph can appear nested "inside" of a paragraph.
Member
|
Thanks for this fix. I have updated the snapshots locally and unfortunately it breaks the snapshot |
Contributor
Author
|
That's ... a problem! I just tested adding more paragraphs to the abstact in |
Contributor
Author
|
I looked a bit into the plos problem, but couldn't figure it out. I thought the decoder should be able to handle an array of paragraphs as an abstract. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously all
<p>s in an abstract would be rendered. With footnotesa paragraph can appear nested "inside" of a paragraph.
Before:
{ "type": "Article", "description": [ { "type": "Paragraph", "content": [ "The abstract can contain a footnote.", { "type": "Note", "id": "note-1", "noteType": "Footnote", "content": [ { "type": "Paragraph", "id": "footnote1", "content": [ "A footnote from the abstract." ] } ] } ] }, { "type": "Paragraph", "id": "footnote1", "content": [ "A footnote from the abstract." ] } ],With using
childreninstead ofall:I tried updating the fixtures, but couldn't get it to work, even with
--clearCache.