Support signed payload revoke signer sponsorship#968
Open
chrisx9z wants to merge 1 commit into
Open
Conversation
Comment: Adds CAP-40 signed payload signer support to revoke signer sponsorship parsing and building.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
signerKeyTypeEd25519SignedPayloadparsing inconvertXDRSignerKeyToObject.Operation.revokeSignerSponsorshipto build revoke-signer sponsorship ops for P-address signers.Operation.fromXDRObjectoutput.Fixes #966.
Verification
corepack yarn install --ignore-scriptscorepack yarn mocha test/unit/operations/classic_ops_test.js --grep "signed payload signer|revokeSignerSponsorship" --require @babel/register --require ./test/test-helper.jscorepack yarn eslint -c ./config/.eslintrc.js src/operation.js src/operations/revoke_sponsorship.jsnode --check src/operation.jsnode --check src/operations/revoke_sponsorship.jsnode --check test/unit/operations/classic_ops_test.jsgit diff --checkNote
test/unit/operations/classic_ops_test.jsfile reports existing style violations unrelated to this change, so source files were linted directly and the changed test path was verified with the focused mocha run and syntax check.