[codex] fix(chrome): clarify daemon setup diagnostics#356
Conversation
|
Codex review: needs maintainer review before merge. Reviewed July 10, 2026, 10:17 AM ET / 14:17 UTC. Summary Reproducibility: yes. Current-main source and the linked report provide a high-confidence path where the side-panel Connect action opens generic Options without directing the user to Runtime diagnostics; the review did not execute that pre-fix flow locally. Review metrics: 3 noteworthy metrics.
Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Next step before merge
Security Review detailsBest possible solution: Merge the proven exact head through normal maintainer review, then close the linked issue when the extension change ships and ensure the matching Chrome Web Store package follows repository release policy. Do we have a high-confidence way to reproduce the issue? Yes. Current-main source and the linked report provide a high-confidence path where the side-panel Connect action opens generic Options without directing the user to Runtime diagnostics; the review did not execute that pre-fix flow locally. Is this the best way to solve the issue? Yes. The patch reuses the existing Runtime setup surface, constrains deep links to known tabs, preserves stored runtime choices, and retains fallback Options opening behavior. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 206a6f844764. Label changesLabel justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
Review history (7 earlier review cycles)
|
Summary
?tab=runtimetarget after the user switches tabs, so reload stays on the user's selected Options tab.Addresses #352.
Behavior proof
Live Chrome diagnostic output from the built extension loaded in a Chromium extension context, with the extension ID redacted:
{ "browser": "chromium extension context", "action": "clicked #daemonHintAction in sidepanel.html", "openedUrl": "chrome-extension://<extension-id>/options.html?tab=runtime", "runtimeTabSelected": "true", "runtimePanelVisible": true, "daemonStatus": "Local companion permission missing — enable it in Runtime settings" }Built Chrome extension Playwright output now covers the same Connect -> Runtime flow against the packaged
chrome-mv3build:The Options URL regression now covers switching away from a requested Runtime deep link, clearing the stale query target, reloading, and staying on the user's selected tab:
Daemon status regression output covers the actionable failure states, including the follow-up installed-host exit case:
The status surface now distinguishes
Daemon runtime off,Local companion permission missing,Native host unavailable,Native host exited, and generic daemon unreachable states without auto-enabling Daemon mode.Validation
pnpm -s checkpnpm -C apps/chrome-extension buildpnpm -s exec vitest run tests/options.tab-controller.test.tsenv -u NO_COLOR SUMMARIZE_E2E_HTTP_TRANSPORT=1 pnpm -C apps/chrome-extension exec playwright test -c playwright.config.ts --project=chromium tests/options.spec.ts tests/sidepanel.core.spec.ts --grep "requested runtime tab|Connect opens Runtime|permission diagnostics|sidepanel default"