fix(extension): split debugger automation build#350
Conversation
|
Codex review: needs maintainer review before merge. Reviewed July 8, 2026, 2:14 AM ET / 06:14 UTC. Summary Reproducibility: not applicable. as a bug reproduction: this PR changes the extension permission and build model rather than reporting a current-main failure. The source diff and added tests give a high-confidence review path for the changed behavior. Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Maintainer decision needed
Security Review detailsBest possible solution: Ship the least-privilege standard Chrome/Web Store build only after maintainers confirm the debugger-enabled automation artifact is packaged, documented, and distributed through the intended non-Web-Store path. Do we have a high-confidence way to reproduce the issue? Not applicable as a bug reproduction: this PR changes the extension permission and build model rather than reporting a current-main failure. The source diff and added tests give a high-confidence review path for the changed behavior. Is this the best way to solve the issue? Yes for the implementation shape, pending maintainer acceptance of the release tradeoff. A separate automation build is a maintainable way to remove AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 206a6f844764. Label changesLabel justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
Review history (1 earlier review cycle)
|
Summary
userScriptsfrom required to optional permissions and request it only from the explicit Options actiondebuggerfrom the standard summary/Web Store build and hide debugger-backed tools therebuild:automation/dev:automationfor the full agentic build, where Chrome requiresdebuggerat install timeSecurity review notes
Chrome explicitly does not allow
debuggerto be declared optional. The standard build therefore has no debugger declaration or grant. The separate automation build declares it as required only for native click/type/key input and the explicit debugger tool; debugger-backed commands attach for the command and detach afterward.userScriptsremains optional in both builds. It is requested only after the user clicks Enable automation permissions, and is used for user-requestedbrowserjs()/ REPL execution in the page main world. Summarization, chat, and browser media do not need either capability.Validation
pnpm test— 2,944 passed, 43 skippedpnpm lintpnpm typecheckpnpm format:check