Add quota warning thresholds#831
Closed
Alekstodo wants to merge 1 commit intosteipete:mainfrom
Closed
Conversation
Contributor
Author
|
Closing for now while we continue local validation before opening the upstream PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProviderConfigand inherit global settings until customized.SessionQuotaNotifier/UsageStorenotification path and keeps depleted/restored 0% behavior unchanged.Notes
Testing
DEVELOPER_DIR=/Applications/Xcode.app/Contents/Developer swift test --filter QuotaWarningDEVELOPER_DIR=/Applications/Xcode.app/Contents/Developer swift test --filter UsageStoreSessionQuotaTransitionTestsDEVELOPER_DIR=/Applications/Xcode.app/Contents/Developer swift test --filter SettingsStoreTestsDEVELOPER_DIR=/Applications/Xcode.app/Contents/Developer swift test --filter CodexActiveSourceConfigTestsDEVELOPER_DIR=/Applications/Xcode.app/Contents/Developer ./Scripts/lint.sh lintDEVELOPER_DIR=/Applications/Xcode.app/Contents/Developer swift testbuilds and runs, but the full suite currently reports 4 failures in existing HistoricalUsagePace tests unrelated to this change.DEVELOPER_DIR=/Applications/Xcode.app/Contents/Developer ./Scripts/compile_and_run.shbuilds the release binary, then fails during ad-hoc codesigning/packaging because the generatedCodexBar.app/ bundledSparkle.frameworkhas macOS resource-fork/Finder metadata.