fix: ensure EnvironmentVariables.clear properly removes variables - #89
Open
arimu1 wants to merge 1 commit into
Open
fix: ensure EnvironmentVariables.clear properly removes variables#89arimu1 wants to merge 1 commit into
arimu1 wants to merge 1 commit into
Conversation
Always update the internal buffer when set/clear is called, including while a test statement is executing. Previously, changes made during a test only modified the live environment map, so a later clear() did not override buffered values from rule configuration and the variable could reappear when the next test started. Fixes stefanbirkner#86
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EnvironmentVariablesbuffer in sync whenset()/clear()are called during test execution.clear()could appear to have no effect when another test had already run and the next test copied stale buffer entries back into the environment.@Beforesetup plusclear()across multiple tests in a class.Fixes #86
Test plan
mvn testEnvironmentVariablesClearAcrossTestsTestwith scenarios for clearing variables set in@Beforeand ensuring cleared variables are not restored from the buffer in subsequent tests