Skip to content

Location Minor Fix#52

Merged
dan-tang-ssd merged 3 commits into
devfrom
locations-minor-fix
Jul 20, 2026
Merged

Location Minor Fix#52
dan-tang-ssd merged 3 commits into
devfrom
locations-minor-fix

Conversation

@dan-tang-ssd

@dan-tang-ssd dan-tang-ssd commented Jul 20, 2026

Copy link
Copy Markdown
Member

This PR is submitted to fix minor issues for locations modules.

This PR needs to be reviewed together with stats4sd/filament-odk-link#128

@dan-tang-ssd dan-tang-ssd changed the title Location Minor DF Location Minor Fix Jul 20, 2026
@dan-tang-ssd

Copy link
Copy Markdown
Member Author

I am testing the cross-team scoping issue.

Team 1, locations can be published to Farm Registration form.
Team 2, error occurred when publishing form in Admin Panel > Teams > Team 2 > Xlsform tab page.

For xlsform_modules_versions table, it does not allow two records with same xlsform_module_id and name.


Screen shots:

image image

@dan-tang-ssd

Copy link
Copy Markdown
Member Author

After including owner_id to xlsform_module_versions table unique key, which contains column xlsform_module_id, name originally. I can publish Farm Registration form for Team 2.

Team 1 form shows Team 1 locations only.
Team 2 form shows Team 2 locations only. (location names with postfix "c")
The cross-team locations scoping issue is resolved.


Screen shots:

Team 1

image image

Team 2

image image

@dan-tang-ssd
dan-tang-ssd requested a review from dave-mills July 20, 2026 13:16
@dan-tang-ssd
dan-tang-ssd merged commit 439b046 into dev Jul 20, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant