Fix/translation uploader issue 36#51
Merged
Merged
Conversation
…ard-coded column G The importer assumed exactly one template language and always read column G, so templates with several default languages imported the wrong language's text (issue #36). The target column is now resolved from the header row via TranslationUploadInspector, and import validation now checks every row per chunk against the template's own survey rows and choice entries instead of the first row only.
…es and protect identifier columns Bumps the filament-odk-link submodule to the matching export fix and adds the export test coverage (owner-filtered reference columns, verified-empty template, sheet protection).
…and validate uploads before import Both download actions shared one Filament action name and both passed withExistingStrings: true, so the empty-template button returned the existing translations. Uploads are now validated against the template before the import is queued (headers, target column, entry ids), and submit() only processes the team's own templates. Also hardens the file-upload label against non-array state.
…slations table Locales created by any team were visible to every team that selected the language. Cross-team sharing is intentionally disabled until a structured sharing/review flow exists. Also removes the dead validateFileUpload method, an unused mount parameter, and a stray newline in a view name.
…ot column typo The component was not embedded anywhere, hardcoded first/last form selection, and always produced empty exports under a household-survey filename. The Locale::owners() pivot referenced 'langauge_id', so the pivot attribute was always null.
Also switches two test assertions to block closures to avoid a Pest Expectation covariance false-positive under phpstan.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #36: