refactor: simplify card validation and option parsing - #121
Open
marcalexiei wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Hi @martin-mfg, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
supportedCoreExports, the handler map and the required-optionswitchwith a singleCARDSmap (card type → core export + required option); adding a card is now a one-line change.createCardHandlers+validateCardOptionswithresolveCardHandler, which validates the card type, core exports and required option, then returns the handler.normalizeOptionsintoparseOptions, usingURLSearchParams.getAll(key).join(",")instead of manual duplicate-key merging.username→GITHUB_REPOSITORY_OWNERfallback intorun(), since it's action behavior rather than card logic.