fix: restore missing normalization of Dirichlet samples#378
Merged
Conversation
This was broken by commit a239ebe (statrs-dev#253). Fixes statrs-dev#344. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Contributor
|
Ah of course! Thanks for the fix. |
Contributor
|
If you would, another PR with a test for this would be great. You wouldn't even need fixed seed for this one since it's a constraint for each output. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #378 +/- ##
==========================================
- Coverage 94.39% 94.39% -0.01%
==========================================
Files 59 59
Lines 12981 12982 +1
==========================================
Hits 12254 12254
- Misses 727 728 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was broken by commit a239ebe (#253, cc @YeungOnion).
Dirichlet::sample()is incorrect #344.