apollo_gateway: stop auto-discovering bench helper as a bench target#14878
Draft
avi-starkware wants to merge 1 commit into
Draft
Conversation
benches/utils.rs is a helper module included by benches/main.rs (the explicit [[bench]], gated on the `testing` feature). Cargo's bench auto-discovery also picked utils.rs up as a standalone, feature-less bench target, so `cargo bench`/`cargo clippy --benches` failed to compile it without `--features testing` (it references apollo_gateway::test_utils). Set autobenches = false so only the explicit [[bench]] is a bench target. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
This change is |
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
benches/utils.rs is a helper module included by benches/main.rs (the explicit
[[bench]], gated on the
testingfeature). Cargo's bench auto-discovery alsopicked utils.rs up as a standalone, feature-less bench target, so
cargo bench/cargo clippy --benchesfailed to compile it without--features testing(it references apollo_gateway::test_utils). Setautobenches = false so only the explicit [[bench]] is a bench target.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com