Skip to content

Upload leaf_prover and recursive_tree arch binaries#410

Open
YairVaknin-starkware wants to merge 2 commits into
mainfrom
yairv/add_new_bins_to_ul_workflows
Open

Upload leaf_prover and recursive_tree arch binaries#410
YairVaknin-starkware wants to merge 2 commits into
mainfrom
yairv/add_new_bins_to_ul_workflows

Conversation

@YairVaknin-starkware

@YairVaknin-starkware YairVaknin-starkware commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

What

Add build + upload steps for the two additional binaries, mirroring the existing stwo_run_and_prove flavors so the backend can pull CPU-optimized builds:

  • leaf_prover: generic (x86_64) + 6 CPU targets (znver3/4/5, emeraldrapids, sapphirerapids, graniterapids).
  • stwo_run_and_prove_recursive_tree: 6 CPU targets (the generic build is already uploaded).

All land under sharp-binary-artifacts/<product>_artifacts/<hash>/release, consistent with the single-bucket layout.

Naming notes

  • leaf-prover's Cargo bin target is hyphenated (like stwo-run-and-prove), so the x86_64 build is renamed to leaf_prover before upload; the build-arch-binary action derives the underscore name for the arch builds.
  • stwo_run_and_prove_recursive_tree's bin target already uses underscores (explicit [[bin]]), so it's passed as-is.

Consumer side

The backend wiring that pulls and selects these (consts.bzl / WORKSPACE / BUILD / Python CPU selection) is a separate starkware-side change; it depends on these buckets/folders being populated by this workflow first.

🤖 Generated with Claude Code


This change is Reviewable

Add build+upload steps for the two additional binaries, mirroring the existing
stwo_run_and_prove flavors so the backend can pull CPU-optimized builds:

- leaf_prover: generic (x86_64) plus the 6 CPU targets (znver3/4/5,
  emeraldrapids, sapphirerapids, graniterapids). Like stwo-run-and-prove, the
  crate's bin target is hyphenated, so the x86_64 build is renamed to
  leaf_prover before upload; the arch action derives the underscore name.
- stwo_run_and_prove_recursive_tree: the 6 CPU targets (the generic build is
  already uploaded above). Its bin target already uses underscores.

All land under sharp-binary-artifacts/<product>_artifacts/<hash>/release,
consistent with the single-bucket layout.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@YairVaknin-starkware
YairVaknin-starkware force-pushed the yairv/add_new_bins_to_ul_workflows branch 2 times, most recently from 404fbdb to ef420cc Compare July 23, 2026 07:44
@cursor

cursor Bot commented Jul 23, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
CI-only changes that add artifact upload steps; no runtime application or security-sensitive logic is modified.

Overview
Extends Upload-Artifacts so leaf_prover and stwo_run_and_prove_recursive_tree get the same GCS publishing pattern as stwo_run_and_prove.

The workflow now uploads a generic x86_64 leaf_prover (renamed from the leaf-prover Cargo bin) to sharp-binary-artifacts/leaf_prover_artifacts/<hash>/release. It also runs build-arch-binary for six CPU targets (znver3/4/5, emeraldrapids, sapphirerapids, graniterapids) for both leaf-prover and stwo_run_and_prove_recursive_tree, matching the existing arch artifact layout.

Note: The push trigger currently includes branch yairv/add_new_bins_to_ul_workflows in addition to main (likely for testing this PR).

Reviewed by Cursor Bugbot for commit ef420cc. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ef420cc. Configure here.

push:
branches:
- main
- yairv/add_new_bins_to_ul_workflows

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upload workflow missing main trigger

High Severity

The push trigger lists only yairv/add_new_bins_to_ul_workflows and no longer includes main. After merge, pushes to main will not run Upload-Artifacts, so release binaries (including the new leaf_prover and arch stwo_run_and_prove_recursive_tree uploads) would stop being published from the default branch.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit ef420cc. Configure here.

@YairVaknin-starkware
YairVaknin-starkware force-pushed the yairv/add_new_bins_to_ul_workflows branch from ef420cc to 404fbdb Compare July 23, 2026 07:50
@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.86%. Comparing base (4c777d3) to head (ef420cc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #410   +/-   ##
=======================================
  Coverage   67.86%   67.86%           
=======================================
  Files          42       42           
  Lines        5459     5459           
=======================================
  Hits         3705     3705           
  Misses       1754     1754           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@YairVaknin-starkware
YairVaknin-starkware force-pushed the yairv/add_new_bins_to_ul_workflows branch from df6a369 to f3cc389 Compare July 23, 2026 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant