Upload leaf_prover and recursive_tree arch binaries#410
Upload leaf_prover and recursive_tree arch binaries#410YairVaknin-starkware wants to merge 2 commits into
Conversation
Add build+upload steps for the two additional binaries, mirroring the existing stwo_run_and_prove flavors so the backend can pull CPU-optimized builds: - leaf_prover: generic (x86_64) plus the 6 CPU targets (znver3/4/5, emeraldrapids, sapphirerapids, graniterapids). Like stwo-run-and-prove, the crate's bin target is hyphenated, so the x86_64 build is renamed to leaf_prover before upload; the arch action derives the underscore name. - stwo_run_and_prove_recursive_tree: the 6 CPU targets (the generic build is already uploaded above). Its bin target already uses underscores. All land under sharp-binary-artifacts/<product>_artifacts/<hash>/release, consistent with the single-bucket layout. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
404fbdb to
ef420cc
Compare
PR SummaryLow Risk Overview The workflow now uploads a generic x86_64 Note: The push trigger currently includes branch Reviewed by Cursor Bugbot for commit ef420cc. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ef420cc. Configure here.
| push: | ||
| branches: | ||
| - main | ||
| - yairv/add_new_bins_to_ul_workflows |
There was a problem hiding this comment.
Upload workflow missing main trigger
High Severity
The push trigger lists only yairv/add_new_bins_to_ul_workflows and no longer includes main. After merge, pushes to main will not run Upload-Artifacts, so release binaries (including the new leaf_prover and arch stwo_run_and_prove_recursive_tree uploads) would stop being published from the default branch.
Reviewed by Cursor Bugbot for commit ef420cc. Configure here.
ef420cc to
404fbdb
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #410 +/- ##
=======================================
Coverage 67.86% 67.86%
=======================================
Files 42 42
Lines 5459 5459
=======================================
Hits 3705 3705
Misses 1754 1754 🚀 New features to boost your workflow:
|
df6a369 to
f3cc389
Compare


What
Add build + upload steps for the two additional binaries, mirroring the existing
stwo_run_and_proveflavors so the backend can pull CPU-optimized builds:All land under
sharp-binary-artifacts/<product>_artifacts/<hash>/release, consistent with the single-bucket layout.Naming notes
leaf-prover's Cargo bin target is hyphenated (likestwo-run-and-prove), so the x86_64 build is renamed toleaf_proverbefore upload; thebuild-arch-binaryaction derives the underscore name for the arch builds.stwo_run_and_prove_recursive_tree's bin target already uses underscores (explicit[[bin]]), so it's passed as-is.Consumer side
The backend wiring that pulls and selects these (consts.bzl / WORKSPACE / BUILD / Python CPU selection) is a separate starkware-side change; it depends on these buckets/folders being populated by this workflow first.
🤖 Generated with Claude Code
This change is