Add the mock circuit verifier's input hint#394
Conversation
PR SummaryLow Risk Overview A new Reviewed by Cursor Bugbot for commit 4fb6a87. Bugbot is set up for automated code reviews on this repo. Configure here. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## yairv/aggregator_program_hash_scope_var #394 +/- ##
===========================================================================
+ Coverage 67.80% 68.42% +0.62%
===========================================================================
Files 41 42 +1
Lines 5892 6011 +119
===========================================================================
+ Hits 3995 4113 +118
- Misses 1897 1898 +1
🚀 New features to boost your workflow:
|
d2650b2 to
646f18a
Compare
70a5b9a to
840f112
Compare
OmriEshhar1
left a comment
There was a problem hiding this comment.
@OmriEshhar1 reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Gali-StarkWare and YairVaknin-starkware).
crates/cairo-program-runner-lib/src/hints/circuit_applicative_bootloader_hints.rs at r1 (raw file):
consider naming the file mock_circuit_verifier_hints.rs (instead of circuit_applicative_bootloader_hints.rs)
OmriEshhar1
left a comment
There was a problem hiding this comment.
@OmriEshhar1 made 1 comment and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Gali-StarkWare).
crates/cairo-program-runner-lib/src/hints/circuit_applicative_bootloader_hints.rs at r1 (raw file):
Previously, OmriEshhar1 wrote…
consider naming the file mock_circuit_verifier_hints.rs (instead of circuit_applicative_bootloader_hints.rs)
OK. I see in PR 395 that you decided to put the hints of circuit_applicative_bootloader and the hints of mock_circuit_verifier in the same place.
I'll leave it to you to decide if you want to keep it in 1 file, or separate to 2 files.
(changed to non-blocking)
OmriEshhar1
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Gali-StarkWare and YairVaknin-starkware).
Implements MOCK_CIRCUIT_VERIFIER_LOAD_INPUT for the mock circuit verifier program (starkware/cairo/cairo_verifier/mock_circuit_verifier.cairo): loads the MockCircuitVerifierInput program input and sets ids.preprocessed_root / ids.output_values (eight u32 words each, in fresh segments) and ids.n_steps. The mock stands in for the real stwo circuit verifier in the circuit-unpacking applicative bootloader's flow tests (added separately): it computes the same output digest D from the given root and output values. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
840f112 to
efc698e
Compare
646f18a to
4fb6a87
Compare
YairVaknin-starkware
left a comment
There was a problem hiding this comment.
@YairVaknin-starkware made 1 comment and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Gali-StarkWare).
crates/cairo-program-runner-lib/src/hints/circuit_applicative_bootloader_hints.rs at r1 (raw file):
Previously, OmriEshhar1 wrote…
OK. I see in PR 395 that you decided to put the hints of circuit_applicative_bootloader and the hints of mock_circuit_verifier in the same place.
I'll leave it to you to decide if you want to keep it in 1 file, or separate to 2 files.
(changed to non-blocking)
I prefer it that way since it's only one hint that will only be used in the context of the circuit applicative bl anyway.
Gali-StarkWare
left a comment
There was a problem hiding this comment.
just move the tests to a different file
@Gali-StarkWare reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on YairVaknin-starkware).
Implements
MOCK_CIRCUIT_VERIFIER_LOAD_INPUTfor the mock circuit verifier program (starkware/cairo/cairo_verifier/mock_circuit_verifier.cairo, added on the main-repo side): loads theMockCircuitVerifierInputprogram input and sets ids.preprocessed_root / ids.output_values (eight u32 words each, in fresh segments) and ids.n_steps. The mock stands in for the real stwo circuit verifier in the circuit-unpacking applicative bootloader's flow tests: it computes the same output digest D from the given root and output values.Stack (2/3): aggregator scope var (#393) ← this ← circuit applicative BL hints.
🤖 Generated with Claude Code
This change is